Updated Branches:
  refs/heads/master 8c2dc53a8 -> 61cbc2371

WICKET-4781 Downgrade the warning that a rendering falls back to 
redirect_to_buffer to a DEBUG

Log the state of the conditions when falling back to REDIRECT_TO_BUFFER for 
easier debugging.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/61cbc237
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/61cbc237
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/61cbc237

Branch: refs/heads/master
Commit: 61cbc23717e5cb4b9ac91c8c4af6ca84a3b54cae
Parents: 8c2dc53
Author: Martin Tzvetanov Grigorov <[email protected]>
Authored: Tue Sep 25 17:38:55 2012 +0300
Committer: Martin Tzvetanov Grigorov <[email protected]>
Committed: Tue Sep 25 17:39:57 2012 +0300

----------------------------------------------------------------------
 .../request/handler/render/WebPageRenderer.java    |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/61cbc237/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java
 
b/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java
index ac0d0d7..46ee1b4 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java
@@ -16,6 +16,7 @@
  */
 package org.apache.wicket.request.handler.render;
 
+import org.apache.wicket.Application;
 import org.apache.wicket.core.request.handler.RenderPageRequestHandler;
 import 
org.apache.wicket.core.request.handler.RenderPageRequestHandler.RedirectPolicy;
 import org.apache.wicket.protocol.http.BufferedWebResponse;
@@ -228,9 +229,15 @@ public class WebPageRenderer extends PageRenderer
                }
                else
                {
-                       if (isRedirectToBuffer() == false && 
logger.isWarnEnabled())
+                       if (isRedirectToBuffer() == false && 
logger.isDebugEnabled())
                        {
-                               logger.debug("Falling back to 
Redirect_To_Buffer render strategy because none of the conditions matched.");
+                               String details = String.format("redirect 
strategy: '%s', isAjax: '%s', redirect policy: '%s', " +
+                                               "current url: '%s', target url: 
'%s', is new: '%s', is stateless: '%s', is temporary: '%s'",
+                                               
Application.get().getRequestCycleSettings().getRenderStrategy(),
+                                               isAjax, getRedirectPolicy(), 
currentUrl, targetUrl, getPageProvider().isNewPageInstance(),
+                                               getPage().isPageStateless(), 
isSessionTemporary());
+                               logger.debug("Falling back to 
Redirect_To_Buffer render strategy because none of the conditions " +
+                                               "matched. Details: " + details);
                        }
 
                        // redirect to buffer

Reply via email to