[ 
https://issues.apache.org/jira/browse/WICKET-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633959#comment-13633959
 ] 

Rob Audenaerde commented on WICKET-5147:
----------------------------------------

I think the problem is in the BaseWicketTester:

transferRequestCookies();

                response = new MockHttpServletResponse(request);

                // Preserve response cookies in redirects
                // XXX: is this really needed ? Browsers wont do that, but some
                // Wicket tests assert that a cookie is in the response,
                // even after redirects (see 
org.apache.wicket.util.cookies.SetCookieAndRedirectTest.statefulPage())
                // They should assert that the cookie is in the next *request*
                if (lastResponse != null && lastResponse.isRedirect())
                {
                        List<Cookie> lastResponseCookies = 
lastResponse.getCookies();
                        for (Cookie cookie : lastResponseCookies)
                        {
                                if (cookie.getMaxAge() != 0)
                                {
                                        // max-age==0 are already handled in 
#transferRequestCookies() above
                                        response.addCookie(cookie);
                                }
                        }
                }


Cookies are transferred in the 'transferRequestCookies()' method. Then, after 
all the cookies are transferred to the request, another run of same cookies are 
added.

                
> WicketTester MockHttpRequest.getCookies very slow / OutOfMemory
> ---------------------------------------------------------------
>
>                 Key: WICKET-5147
>                 URL: https://issues.apache.org/jira/browse/WICKET-5147
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 6.7.0
>            Reporter: Rob Audenaerde
>
> We have an extensive set of WicketTester tests. Recently, the wicket RELEASE 
> in the maven repository changed to 6.7.0. After the new version, our tests 
> got very slow.
> When profiling, I discovered that the MockHttpRequest.getCookies() was taking 
> up a lot of time. Also, tests failed because of OutOfMemory exceptions. My 
> guess is that somehow a lot of objects are created at such speeds that the GC 
> cannot clean them
> I will investigate further, but switching back to 6.6.0 solved the issue. 
> [Edit]
> The tests are run with TestNG and using 'mvn test'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to