[ 
https://issues.apache.org/jira/browse/WICKET-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655933#comment-13655933
 ] 

Sven Meier commented on WICKET-5178:
------------------------------------

The fix works fine for me, thanks!

A minor nitpick:
Even if an event is throttled, _handleEventCancelation() should be called 
nevertheless. Otherwise an event might trigger the default or bubble up because 
the throttled execution is delayed.

--- 
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++ 
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -1797,13 +1797,12 @@
                                                        
throttler.throttle(throttlingSettings.id, throttlingSettings.d,
                                                                
Wicket.bind(function () {
                                                                        
call.ajax(attributes);
-                                                                       
Wicket.Ajax._handleEventCancelation(attributes);
                                                                }, this));
                                                }
                                                else {
                                                        call.ajax(attributes);
-                                                       
Wicket.Ajax._handleEventCancelation(attributes);
                                                }
+                                               
Wicket.Ajax._handleEventCancelation(attributes);
                                        });
                                });
                        },
                
> StopPropagation functionality on link is broken
> -----------------------------------------------
>
>                 Key: WICKET-5178
>                 URL: https://issues.apache.org/jira/browse/WICKET-5178
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 6.7.0
>            Reporter: Marieke Vandamme
>            Assignee: Martin Grigorov
>             Fix For: 6.8.0
>
>         Attachments: myproject.zip
>
>
> In the quickstart I'll add the following is illustrated:
> - simple table with AjaxLink on tr
> - on that tr there's another AjaxLink with should not propagate the onclick 
> to the tr
> - So when clicking the "here" link, on the server logging only the following 
> should appear:
>      * onclick LNK
>  but also the logging from the tr link is printed:
>     * onclick LNK
>     * onclick TR
> In wicket 6.6 this works. 
> Thanks in advance ! Kind regards, Marieke

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to