[ 
https://issues.apache.org/jira/browse/WICKET-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693081#comment-13693081
 ] 

Martin Grigorov commented on WICKET-5179:
-----------------------------------------

Hi Jesse,

Your patch for 7.x has been applied.

>  So, I propose we leave Wicket 6 as it was, and just fix it for wicket 7.
Do you mean that you can wait for this change until 7.0 is released ?
This is how I understood you, but then you attached a patch for 6.x too.
                
> Move Form hidden field rendering to dedicated method
> ----------------------------------------------------
>
>                 Key: WICKET-5179
>                 URL: https://issues.apache.org/jira/browse/WICKET-5179
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.7.0
>         Environment: PanelMarkupSourcingStrategy
>            Reporter: Jesse Long
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 7.0.0
>
>         Attachments: myproject.tar.gz, wicket-5179-6.x.patch, 
> wicket-5179-7.x.patch
>
>
> Form renders its hidden fields in onComponentTagBody(), which is never called 
> when the markup sourcing strategy is PanelMarkupSourcingStrategy. Please can 
> we move this to a dedicated method which can be called from 
> MarkupSourcingStrategy#onComponentTagBody() when the component is instanceof 
> Form.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to