[
https://issues.apache.org/jira/browse/WICKET-5469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867931#comment-13867931
]
Jonas commented on WICKET-5469:
-------------------------------
Wouldn't it make sense to use
window.addEventListener("onbeforeunload", handler)
and
window.removeEventListener("onbeforeunload", handler)
instead of messing with window.onbeforeunload ?
This would probably also avoid the problem described in WICKET-4909
> ModalWindow unload warning always displayed (even if window is closed)
> ----------------------------------------------------------------------
>
> Key: WICKET-5469
> URL: https://issues.apache.org/jira/browse/WICKET-5469
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.13.0, 7.0.0
> Reporter: Jonas
> Priority: Minor
>
> The fix applied for WICKET-4909 seems to be bad:
> If there's a ModalWindow with showUnloadConfirmation == true (java) and
> window.onbeforeunload == null (javascript), the warning message ('Reloading
> this page will cause the modal window to disappear') is always displayed,
> even if the ModalWindow was closed.
> The fix for WICKET-4909 should probably take the showUnloadConfirmation flag
> into account.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
