Intern some strings which appear in the top duplicates in Yourkit memory 
profile when running ComponentQueueingPerformanceTest


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0036f14c
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0036f14c
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0036f14c

Branch: refs/heads/master
Commit: 0036f14c33ffb548cdc8adf9ebf17cec34a73c1f
Parents: 8c3d270
Author: Martin Tzvetanov Grigorov <[email protected]>
Authored: Thu Mar 6 16:03:27 2014 +0200
Committer: Martin Tzvetanov Grigorov <[email protected]>
Committed: Thu Mar 6 16:03:27 2014 +0200

----------------------------------------------------------------------
 .../main/java/org/apache/wicket/markup/MarkupResourceStream.java | 2 +-
 .../src/main/java/org/apache/wicket/markup/parser/XmlTag.java    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/0036f14c/wicket-core/src/main/java/org/apache/wicket/markup/MarkupResourceStream.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/MarkupResourceStream.java 
b/wicket-core/src/main/java/org/apache/wicket/markup/MarkupResourceStream.java
index 6e11b8b..3f70c0e 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/markup/MarkupResourceStream.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/markup/MarkupResourceStream.java
@@ -261,7 +261,7 @@ public class MarkupResourceStream implements 
IResourceStream, IFixedLocationReso
        public final void setWicketNamespace(final String wicketNamespace)
        {
                this.wicketNamespace = wicketNamespace;
-               wicketId = wicketNamespace + ":id";
+               wicketId = (wicketNamespace + ":id").intern();
 
                if (!MarkupParser.WICKET.equals(wicketNamespace) && 
log.isDebugEnabled())
                {

http://git-wip-us.apache.org/repos/asf/wicket/blob/0036f14c/wicket-core/src/main/java/org/apache/wicket/markup/parser/XmlTag.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/markup/parser/XmlTag.java 
b/wicket-core/src/main/java/org/apache/wicket/markup/parser/XmlTag.java
index fc50131..cd3b6d3 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/parser/XmlTag.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/parser/XmlTag.java
@@ -458,7 +458,7 @@ public class XmlTag
        {
                if (isMutable)
                {
-                       this.name = name;
+                       this.name = name.intern();
                }
                else
                {
@@ -476,7 +476,7 @@ public class XmlTag
        {
                if (isMutable)
                {
-                       this.namespace = namespace;
+                       this.namespace = namespace.intern();
                }
                else
                {

Reply via email to