Repository: wicket Updated Branches: refs/heads/master d31415397 -> 8cb208b1d
Small improvement - avoid a instanceof check. If the type is not Component then it will fail with ClassCastException providing the same information about the problem. Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0b37503f Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0b37503f Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0b37503f Branch: refs/heads/master Commit: 0b37503f13aefe57406b3782bd1c49d2883b11ff Parents: d314153 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Tue Mar 18 17:54:21 2014 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Tue Mar 18 17:54:21 2014 +0200 ---------------------------------------------------------------------- .../src/main/java/org/apache/wicket/MarkupContainer.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/0b37503f/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java index b11eb10..68c16f7 100644 --- a/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java +++ b/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java @@ -1092,14 +1092,7 @@ public abstract class MarkupContainer extends Component implements Iterable<Comp */ private String getId(Object object) { - if (object instanceof Component) - { - return ((Component)object).getId(); - } - else - { - throw new IllegalArgumentException("Unknown type of object " + object); - } + return ((Component)object).getId(); } /**
