[jira] [Commented] (WICKET-5624) Do not throw when WebSocket is not supported

[Andrei Badea (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WICKET-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038760#comment-14038760
 ] 

Andrei Badea commented on WICKET-5624:
--------------------------------------

So the (very complex) patch would go like this :-)

{noformat}
diff --git 
a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/res/js/wicket-websocket-jquery.js
 b/wicket-native-websocket/wicket
index 4e8f68d..d24647b 100644
--- 
a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/res/js/wicket-websocket-jquery.js
+++ 
b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/res/js/wicket-websocket-jquery.js
@@ -91,7 +91,6 @@
                        } else {
                                var errMessage = '[WebSocket.initialize] 
WebSocket is not supported in your browser!';
                                Wicket.Log.error(errMessage);
-                               throw errMessage;
                        }
                },
 
{noformat}


> Do not throw when WebSocket is not supported
> --------------------------------------------
>
>                 Key: WICKET-5624
>                 URL: https://issues.apache.org/jira/browse/WICKET-5624
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-native-websocket
>    Affects Versions: 6.15.0
>            Reporter: Andrei Badea
>            Assignee: Martin Grigorov
>
> When the browser does not support WebSocket, /wicket-websocket-jquery.js 
> throws an "is not supported" string from the initialize() method, which runs 
> in the DOM ready event. This break any other initialization of the page that 
> takes place after the WebSocket initialization, leading to less than graceful 
> degradation of functionality.



--
This message was sent by Atlassian JIRA
(v6.2#6252)