[ https://issues.apache.org/jira/browse/WICKET-5350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075620#comment-14075620 ]
Carl-Eric Menzel commented on WICKET-5350: ------------------------------------------ Well, I think wildcards should only be used if there is really no other way. I don't mind if a method signature carries a few extra type parameters, those usually get inferred at the call site. Wildcards on the other hand almost always get in the way, especially since they make collections essentially read-only. Why not in Wicket 7, though? I understand we can't change the signatures for 6, but in 7 it should be okay. > Enhancement for AbstractChoice and WildcardListModel API > -------------------------------------------------------- > > Key: WICKET-5350 > URL: https://issues.apache.org/jira/browse/WICKET-5350 > Project: Wicket > Issue Type: Improvement > Affects Versions: 6.10.0, 7.0.0-M1 > Reporter: Betlista > Assignee: Sven Meier > Priority: Minor > Labels: generics > > According to Efective Java book > (http://devender.files.wordpress.com/2008/05/effectivejava.pdf), item 28: > "No wildcard type for return value" > Especially "User should not have to think about wildcards to use your API". > so > public List<? extends E> getChoices() > should be changed to > public List<E> getChoices() > and for WildcardListModel > protected List<? extends T> createSerializableVersionOf(List<? extends T> > object) > should be changed to > protected List<T> createSerializableVersionOf(List<? extends T> object) > Probably there is a lot of such things in framework. -- This message was sent by Atlassian JIRA (v6.2#6252)