Repository: wicket Updated Branches: refs/heads/master d558004bb -> ebd01006f
Make the check for empty property expression stronger - it should trim the expression before checking for emptiness (cherry picked from commit 0639719c03a08071db21162238fda9d5f5001dc5) Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/06913941 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/06913941 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/06913941 Branch: refs/heads/master Commit: 069139412ce4b553375ac1a3006aaa9f5783091f Parents: d558004 Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Mon Aug 4 09:11:12 2014 +0200 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Mon Aug 4 09:15:13 2014 +0200 ---------------------------------------------------------------------- .../java/org/apache/wicket/core/util/lang/PropertyResolver.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/06913941/wicket-core/src/main/java/org/apache/wicket/core/util/lang/PropertyResolver.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/core/util/lang/PropertyResolver.java b/wicket-core/src/main/java/org/apache/wicket/core/util/lang/PropertyResolver.java index b39d853..5b668c4 100644 --- a/wicket-core/src/main/java/org/apache/wicket/core/util/lang/PropertyResolver.java +++ b/wicket-core/src/main/java/org/apache/wicket/core/util/lang/PropertyResolver.java @@ -127,7 +127,7 @@ public final class PropertyResolver public static void setValue(final String expression, final Object object, final Object value, final PropertyResolverConverter converter) { - if (expression == null || expression.equals("")) + if (Strings.isEmpty(expression)) { throw new WicketRuntimeException("Empty expression setting value: " + value + " on object: " + object);
