[ 
https://issues.apache.org/jira/browse/WICKET-5539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092720#comment-14092720
 ] 

Guillaume Smet commented on WICKET-5539:
----------------------------------------

Hi Martin,

Thanks for pursuing this.

The workaround for 6 looks OK to me. It's not pretty but it does the job.

I like what you did in your branch. Maybe it would be a good idea to provide a 
way to configure:
- which parameters have to be kept using the names
- which parameters have to be kept using the types you introduced
when you define the mapping?

I don't have a specific need for it myself but I think it might be something 
cool in case someone really wants to define the behavior specifically.

> Incorrect recreation of page in case of PageExpire
> --------------------------------------------------
>
>                 Key: WICKET-5539
>                 URL: https://issues.apache.org/jira/browse/WICKET-5539
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.14.0
>            Reporter: Ilia Naryzhny
>            Assignee: Martin Grigorov
>              Labels: expiration, mountBookmarkablePage
>             Fix For: 6.17.0
>
>         Attachments: wicket5539.zip
>
>
> There is a bookmarkable page mounted, for example, to:
> /page/${entityId}
> This page contains StatelessForm.
> Submitting of form after session expire lead to following:
> org.apache.wicket.core.request.mapper.MountedMapper invokes 
> AbstractBookmarkableMapper.processListener to obtain IRequestHandler to 
> handle submitting of form. 
> But there is cleaning of PageParameters within processListener on line 256 
> (Wicket 6.14) which cleaning "entityId" parameter as well and created page 
> finally has no "enityId" and (in our case) redirects to 404.
> I see that this cleaning of page parameters was implemented due to 
> Wicket-4594. But I think, just checking for pageId is unsufficient, because 
> pageId might be not null, but actual page may be already expired and new 
> instance should be created.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to