[
https://issues.apache.org/jira/browse/WICKET-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106796#comment-14106796
]
ASF subversion and git services commented on WICKET-5656:
---------------------------------------------------------
Commit bc4a55fccea6810d0970d924fdd9d84392960995 in wicket's branch
refs/heads/wicket-6.x from adelbene
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=bc4a55f ]
WICKET-5656 PropertyResolver does not scan for NotNull in annotation
tree
> PropertyResolver does not scan for NotNull in annotation tree
> -------------------------------------------------------------
>
> Key: WICKET-5656
> URL: https://issues.apache.org/jira/browse/WICKET-5656
> Project: Wicket
> Issue Type: Bug
> Components: wicket-bean-validation
> Affects Versions: 6.16.0
> Reporter: Thibault Kruse
> Assignee: Igor Vaynberg
>
> When annotating a field of a bean with e.g.
> org.hibernate.validator.constraints.NotEmpty, this implies
> javax.validation.constraints.NotNull, but PropertyValidator only checks for
> the annotations immediately on the filed not the tree of annotations. As a
> result Wicket does not mark the field as required in the UI, which it should.
> Also PropertyResolver.findNotNullConstraints() is not even protected, so
> cannot be patched in a simple way.
> So as a solution I suggest changing findNotNullConstraints() to be protected
> and rather be something like findConstraints(filter), or
> findConstraints(clazz), and then in that method method recursively invoking
> getComposingConstraints to get all constraints, but collecting only those of
> interest. Possibly some care needs to be taken to prevent infinite recursion
> where constraints are composed of each other (if that compiles).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
