[
https://issues.apache.org/jira/browse/WICKET-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189691#comment-14189691
]
Roman Grigoriadi commented on WICKET-5735:
------------------------------------------
I am not disturbed with introducing parse method that much. Not a big fan of
long constructors. Maybe it should be renamed to parseUploads(), because
headers part of request is already parsed. Also by overriding parse() one may
now use any request parsing instead of commons.FileUpload. Different types of
propagation of sizeMax and fileSizeMax looks weird in Form.handleMultiPart()
though, but it is no big deal considering 1.6 will one day be lost in the past
and 1.7 will get the other version of patch.
> Propagate fileSizeMax attribute to
> org.apache.commons.fileupload.FileUploadBase
> -------------------------------------------------------------------------------
>
> Key: WICKET-5735
> URL: https://issues.apache.org/jira/browse/WICKET-5735
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Roman Grigoriadi
> Assignee: Martin Grigorov
> Priority: Minor
>
> Wicket's MultipartServletWebRequestImpl uses commons ServletFileUpload
> internally, but there is no way to configure this component, for example to
> propagate fileSizeMax inside.
> As supposed in
> http://apache-wicket.1842946.n4.nabble.com/org-apache-wicket-util-upload-FileUploadBase-fileSizeMax-td4668001.html
> there should be implemented:
> 1) add Form#fileSizeMax and pass it to MultipartServletWebRequest
> 2) add MultipartServletWebRequestImpl#newFileUpload(FileItemFactory)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
