[ 
https://issues.apache.org/jira/browse/WICKET-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282539#comment-14282539
 ] 

ASF subversion and git services commented on WICKET-5811:
---------------------------------------------------------

Commit 5fe26827a24f4e4eb1a64a96aa0df8f8558b84e7 in wicket's branch 
refs/heads/wicket-6.x from [~amorozov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5fe2682 ]

WICKET-5811 Fix issue with infinite loop in 
PropertyValidator#createUnresolvablePropertyMessage(FormComponent<>) in case or 
trivial model (new Model<>(...));


> Infinite loop issue in 
> PropertyValidator#createUnresolvablePropertyMessage(FormComponent<>) 
> --------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5811
>                 URL: https://issues.apache.org/jira/browse/WICKET-5811
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-bean-validation
>    Affects Versions: 6.18.0, 7.0.0-M4
>         Environment: Windows Pro x64, Oracle JDK 7u72
>            Reporter: Alexander Morozov
>            Assignee: Igor Vaynberg
>             Fix For: 7.0.0-M5, 6.19.0
>
>
> In case of trivial model, attached to a FormComponent, 
> PropertyValidator#createUnresolvablePropertyMessage(FormComponent<>) has no 
> chances to find suitable model and falls into infinite loop.
> {code}
>               IModel<?> model = component.getModel();
>               // Code sadly copied over from DefaultPropertyResolver
>               while (true)
>               {
>                       if (model == null)
>                       {
>                               break;
>                       }
>                       if (model instanceof IPropertyReflectionAwareModel)
>                       {
>                               break;
>                       }
>                       if (model instanceof IWrapModel<?>)
>                       {
>                               model = 
> ((IWrapModel<?>)model).getWrappedModel();
>                               continue;
>                       }
>                         // FIXME issue is here
>               }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to