[ 
https://issues.apache.org/jira/browse/WICKET-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321420#comment-14321420
 ] 

Tobias Soloschenko commented on WICKET-5837:
--------------------------------------------

junit.framework.ComparisonFailure: 
org/apache/wicket/ajax/AjaxHeaderContributionPage_expected.html expected:<...
Wicket.Ajax.ajax({"[u":"./org.apache.wicket.ajax.AjaxHeaderContributionPage?0-1.IBehaviorListener.0-link","e":"click","c":"link1]"});;
Wicket.Event.p...> but was:<...
Wicket.Ajax.ajax({"[c":"link1","u":"./org.apache.wicket.ajax.AjaxHeaderContributionPage?0-1.IBehaviorListener.0-link","e":"click]"});;
Wicket.Event.p...>
        at junit.framework.Assert.assertEquals(Assert.java:85)
        at 
org.apache.wicket.util.tester.DiffUtil.validatePage(DiffUtil.java:160)
        at 
org.apache.wicket.util.tester.WicketTester.assertResultPage(WicketTester.java:590)
        at 
org.apache.wicket.ajax.AjaxHeaderContributionTest.ajaxHeaderContribution(AjaxHeaderContributionTest.java:34)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:483)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
        at 
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
        at 
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
        at 
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)


> JUnit tests may fail because of AbstractDefaultAjaxBehavior
> -----------------------------------------------------------
>
>                 Key: WICKET-5837
>                 URL: https://issues.apache.org/jira/browse/WICKET-5837
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.20.0, 7.0.0-M6
>            Reporter: Tobias Soloschenko
>              Labels: test
>
> Because JSONObject is used in the method 
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.renderAjaxAttributes(Component,
>  AjaxRequestAttributes)
> which internally uses a HashMap to store the key value pairs - see 
> org.apache.wicket.ajax.json.JSONObject.JSONObject() - it is not ensured the 
> attributes rendered in a specific order. This can cause the unit tests to 
> pass in one run and fail in the next run.
> One suggestion would be to switch the HashMap and replace it with at 
> LinkedHashMap to preserve the insertion order.
> See stack trace in comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to