[ https://issues.apache.org/jira/browse/WICKET-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334546#comment-14334546 ]
ASF GitHub Bot commented on WICKET-5749: ---------------------------------------- Github user martin-g commented on the pull request: https://github.com/apache/wicket/pull/99#issuecomment-75711898 LGTM! Just small nitpicks. > Wicket-auth-roles should deal with resource authorization > --------------------------------------------------------- > > Key: WICKET-5749 > URL: https://issues.apache.org/jira/browse/WICKET-5749 > Project: Wicket > Issue Type: Improvement > Components: wicket-auth-roles > Affects Versions: 7.0.0-M3 > Reporter: Carl-Eric Menzel > Assignee: Carl-Eric Menzel > Priority: Minor > > We now have IAuthorizationStrategy.isResourceAuthorized, which is awesome. So > far, wicket-auth-roles's implementation allows all resources to go through > without any possibility of configuring that. > I think the default auth strategy shipped with Wicket should support this :-) > Perhaps an additional annotation like "@AuthorizeResource"? -- This message was sent by Atlassian JIRA (v6.3.4#6332)