[ 
https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358238#comment-14358238
 ] 

ASF GitHub Bot commented on WICKET-5827:
----------------------------------------

Github user martin-g commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/97#discussion_r26283649
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/resource/CssUrlReplacer.java ---
    @@ -43,6 +49,8 @@
        // The pattern to find URLs in CSS resources
        private static final Pattern URL_PATTERN = 
Pattern.compile("url\\(['|\"]*(.*?)['|\"]*\\)");
     
    +   private static final String EMBED_BASE64 = "embedBase64";
    --- End diff --
    
    Please make this `public`.
    An application developer may want to use ...
    And add javadoc what it is about.


> Allow to apply multiple Javascript / CSS compressors
> ----------------------------------------------------
>
>                 Key: WICKET-5827
>                 URL: https://issues.apache.org/jira/browse/WICKET-5827
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 6.20.0, 7.0.0-M6
>            Reporter: Tobias Soloschenko
>            Assignee: Martin Grigorov
>            Priority: Minor
>              Labels: features
>             Fix For: 6.20.0, 7.0.0-M6
>
>
> It would be nice to be able to add several css and javascript compressions in 
> a chain. Example for CSS:
> CssRemoveCommentsCompressor > CssUrlReplacementCompressor > 
> CssMinifyCompressor
> The same would be nice for JavaScript files.
> https://github.com/apache/wicket/pull/88
> https://github.com/apache/wicket/pull/87



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to