[
https://issues.apache.org/jira/browse/WICKET-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493745#comment-14493745
]
ASF GitHub Bot commented on WICKET-5881:
----------------------------------------
GitHub user shuraa opened a pull request:
https://github.com/apache/wicket/pull/115
WICKET-5881 FormComponent#updateCollectionModel must check convertedInpu...
...t for null before wrapping into
ArrayListFormComponent#updateCollectionModel must check convertedInput for null
before wrapping into ArrayList
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shuraa/wicket wicket-6.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 4362e6ee287993715de8867d0952aae775f99b85
Author: Alexander Morozov <amoro...@frte.ru>
Date: 2015-04-14T07:39:31Z
WICKET-5881 FormComponent#updateCollectionModel must check convertedInput
for null before wrapping into ArrayListFormComponent#updateCollectionModel must
check convertedInput for null before wrapping into ArrayList
----
> NPE in FormComponent#updateCollectionModel in case of no converted input and
> unmodifiable collection
> ----------------------------------------------------------------------------------------------------
>
> Key: WICKET-5881
> URL: https://issues.apache.org/jira/browse/WICKET-5881
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.19.0, 7.0.0
> Environment: Windows 7 Pro SP1 x64, JDK 7u75 x64, Wildfly 8.2.0.Final
> Reporter: Alexander Morozov
>
> There are 2 issues with FormComponent#updateCollectionModel. 1) converted
> input is not checked for null before wrapping it to ArrayList 2) converted
> input is not checked for null then model returns unmodifiable collection. The
> both issues causes NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
