[ 
https://issues.apache.org/jira/browse/WICKET-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847603#comment-15847603
 ] 

Jeremy edited comment on WICKET-6286 at 1/31/17 10:07 PM:
----------------------------------------------------------

I like the location enum, seems like a good idea.

Yeah, you should be able to set a cookie in the server response, so I don't see 
any issue with that.
Might be a bit hacky though.

Anti-cache parameters shouldn't be necessary as the first time the browser 
visits it, it'll trigger a download, and should force the browser to not cache 
it, but I may be wrong in that regard.
That's what I'd assume...

Also, a question still remains of it locking the page?
Should we worry about the page being locked?
It would pose a big problem with large downloads, and I don't think you can 
fully detach an AjaxRequestTarget from the originating page, but again, need 
confirmation. (As it locks the page to begin with.)



was (Author: jezza):
I like the location enum, seems like a good idea.

Yeah, you should be able to set a cookie in the server response, so I don't see 
any issue with that.
Might be a bit hacky though.

Anti-cache parameters shouldn't be necessary as the first time the browser 
visits it, it'll trigger a download, and should force the browser to not cache 
it, but I may be wrong in that regard.
That's my thought on it.

Also, a question still remains of it locking the page?
Should we worry about the page being locked?
It would pose a big problem with large downloads, and I don't think you can 
fully detach an AjaxRequestTarget from the originating page, but again, need 
confirmation. (As it locks the page to begin with.)


> Would be good to have AjaxDownload available out of the box 
> ------------------------------------------------------------
>
>                 Key: WICKET-6286
>                 URL: https://issues.apache.org/jira/browse/WICKET-6286
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket-extensions
>    Affects Versions: 8.0.0-M2, 7.5.0
>            Reporter: Maxim Solodovnik
>            Assignee: Sven Meier
>              Labels: patch
>
> Currently every project need to create own AjaxDownload component based on 
> the Wiki example.
> Unfortunately this component has some issues with WebSockets
> Discussion: http://markmail.org/message/gizsnqh2qgypcgri
> PRs:
> https://github.com/apache/wicket/pull/190
> https://github.com/apache/wicket/pull/191



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to