[
https://issues.apache.org/jira/browse/WICKET-6355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965703#comment-15965703
]
ASF GitHub Bot commented on WICKET-6355:
----------------------------------------
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/219#discussion_r111130176
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java ---
@@ -95,7 +95,9 @@ protected ResourceResponse createResourceResponse(Path
path, String fileName)
resourceResponse.setContentType(getMimeType());
resourceResponse.setAcceptRange(ContentRangeType.BYTES);
resourceResponse.setContentLength(size);
- resourceResponse.setFileName(fileName == null ?
path.getFileName().toString() : fileName);
+ if (path != null && path.getFileName() != null) {
--- End diff --
I think we don't need to check *path != null* because it is checked before
(and a WicketRuntimeException is thrown if it is null) - everything else looks
good.
> There should be possible to set fileName to FileSystemResource
> --------------------------------------------------------------
>
> Key: WICKET-6355
> URL: https://issues.apache.org/jira/browse/WICKET-6355
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 8.0.0-M5
> Reporter: Maxim Solodovnik
> Priority: Minor
>
> Currently no fileName is set to FileSystemResource, and there is no easy way
> to do it
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
