[
https://issues.apache.org/jira/browse/WICKET-6459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152559#comment-16152559
]
ASF GitHub Bot commented on WICKET-6459:
----------------------------------------
GitHub user disblader opened a pull request:
https://github.com/apache/wicket/pull/232
Ajax inline enclosure fix.
A fix for the issue I described in WICKET-6459.
I've made this for 7.x as that's the version relevant for me, but I'd like
it to be propogate to 8.x as well, how would I do that? Should I create a new
pull request trying to merge this branch into 8.x?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/disblader/wicket enclosure-ajax
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/232.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #232
----
commit 3b21b3a1d2a2220452eac74ec19e78b2c2d6da4a
Author: Domas Poliakas <dpoliakas@domas-mbp.local>
Date: 2017-09-01T16:39:42Z
Ajax inline enclosure fix.
----
> Ajax re-renders of enclosures do not render their children's header
> contributions
> ---------------------------------------------------------------------------------
>
> Key: WICKET-6459
> URL: https://issues.apache.org/jira/browse/WICKET-6459
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 8.0.0-M6, 7.8.0
> Reporter: Domas Poliakas
> Priority: Minor
>
> When a component in an enclosure is added to the AjaxRequestTarget, its (and
> subsequently its children's) header contributions are not rendered.
> AjaxEnclosureListener replaces any components with enclosures that are in the
> target with their enclosures. However, in the wicket hierarchy the enclosures
> appear to be siblings to the components they enclose. What this causes is
> that when the default ChildFirstHeaderRenderStrategy attempts to render the
> header contributions for the enclosure, nothing is rendered as the enclosure
> itself has no children in the hierarchy.
> On one hand, ChildFirstHeaderRenderStrategy seems to be the culprit - it
> should detect enclosures and act accordingly - but fixing the problem there
> would cause it to resurface in the future if the default implementation of
> header render strategy is changed. What would be a correct way fix for this?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
