[ 
https://issues.apache.org/jira/browse/WICKET-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268054#comment-16268054
 ] 

ASF GitHub Bot commented on WICKET-6501:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/wicket/pull/248


> DefaultPageManagerProvider does not honour 
> StoreSettings.setAsynchronous(false)
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-6501
>                 URL: https://issues.apache.org/jira/browse/WICKET-6501
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.0.0-M8
>            Reporter: Greg Johnson
>            Assignee: Maxim Solodovnik
>            Priority: Minor
>
> StoreSettings.setAsynchronous(false) does not prevent pageStore from being 
> wrapped with AsynchronousPageStore 
> DefaultPageManagerProvider.java:
> if (pageStore.canBeAsynchronous()) 
> {
>     pageStore = new AsynchronousPageStore(pageStore, capacity);
> }
> Suggest:
> if (pageStore.canBeAsynchronous() && storeSettings.isAsynchronous())
> {
>     pageStore = new AsynchronousPageStore(pageStore, capacity);
> }



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to