[
https://issues.apache.org/jira/browse/WICKET-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290542#comment-16290542
]
ASF GitHub Bot commented on WICKET-6503:
----------------------------------------
GitHub user svenmeier opened a pull request:
https://github.com/apache/wicket/pull/250
WICKET-6503 render cleanup and ajax
This is a combined effort to:
- align Ajax requests with the way components are prepared in normal
request, i.e. beforeRender is called on *all* components, before any of them is
rendered
- unify rendering of components separately as part of a page only vs. a
whole page
- improve performance by prevent unnecessary traversal of the component
hierarchy
- cleanup component's internal methods and flags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/wicket
WICKET-6503_ajax_feedback_prepare
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
----
> Ajax refresh and feedback panel
> -------------------------------
>
> Key: WICKET-6503
> URL: https://issues.apache.org/jira/browse/WICKET-6503
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.28.0, 7.9.0, 8.0.0-M8
> Reporter: Martin Makundi
> Assignee: Sven Meier
> Labels: ajax
> Attachments: AjaxRequestTarget.diff.txt,
> Wicket8_Quickstart-IListener.zip, Wicket8_Quickstart-nested.zip,
> Wicket8_Quickstart.zip
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> For normal rendering we have:
> {{{{ /**
> * We need to postpone calling beforeRender() on components that
> implement {@link IFeedback}, to
> * be sure that all other component's beforeRender() has been already
> called, so that IFeedbacks
> * can collect all feedback messages. This is the key under list of
> postponed {@link IFeedback}
> * is stored to request cycle metadata. The List is then iterated over
> in
> * {@link #prepareForRender()} after calling {@link #beforeRender()},
> to initialize postponed
> * components.
> */
> private static final MetaDataKey<List<Component>> FEEDBACK_LIST = new
> MetaDataKey<List<Component>>()
> {
> private static final long serialVersionUID = 1L;
> };
> }}}}
> Should there be similar functionality built in for Ajax update? It seems to
> be a typical problem that the feedback of an ajax update occurs too late.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
