[
https://issues.apache.org/jira/browse/WICKET-5552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628259#comment-16628259
]
ASF GitHub Bot commented on WICKET-5552:
----------------------------------------
Github user solomax commented on a diff in the pull request:
https://github.com/apache/wicket/pull/294#discussion_r220426844
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
---
@@ -2301,6 +2302,10 @@
onDrag = jQuery.noop;
}
+ if (typeof(settings) !== "undefined" &&
settings.stopDragOnCssSelector) {
--- End diff --
According to the code `settings` should be `object`
Maybe it would be better to change this line to be
`typeof(settings) === 'object'` ?
> Events to close pop-up on Modal Window are not propagated
> ---------------------------------------------------------
>
> Key: WICKET-5552
> URL: https://issues.apache.org/jira/browse/WICKET-5552
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.14.0
> Environment: Windows/Eclipse/JRE7
> Reporter: Neil Bennett
> Priority: Major
> Labels: javascript, modalwindow
> Attachments: quickstart.zip
>
>
> When using a field on a modal window that shows a pop-up window, like a time
> picker, when clicking outside of the pop-up window but over the modal window,
> mousedown/click events are not propagated. Clicks outside of the modal window
> are propagated.
> This is due to Wicket.Event.stop(event) being called on mousedown on the
> w_content_1 component. Removal of this leads to the Drag javascript being
> executed which itself calls Wicket.Event.stop(event), disabling this then
> propagates the event which leads to the pop-up window being closed but causes
> any field on the modalwindow to get focus.
> I have a quickstart that demonstrates the modalwindow behavior vs that on a
> page. You will see that launching the modal window and clicking on the time
> component opens the pop-up window. However, you can only get this to close
> when clicking outside of the modal window. The same component has been put on
> the main page as a comparison which does close when clicking outside of the
> pop-up window.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
