[jira] [Commented] (WICKET-6603) WicketTester.destroy sometimes hangs

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WICKET-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663971#comment-16663971
 ] 

ASF GitHub Bot commented on WICKET-6603:
----------------------------------------

Github user svenmeier commented on the issue:

    https://github.com/apache/wicket/pull/300
  
    I like to minimize the count of member variables:
    
    ```
    @Override
    public void destroy()
    {
        final Thread pageSavingThread = this.pageSavingThread;
        this.pageSavingThread = null;
        if (pageSavingThread.isAlive())
        {
                try
                {
                        pageSavingThread.join();
    
    @Override
    public void storePage(String sessionId, IManageablePage page)
    {
        if (pageSavingThread == null)
        {
                return;
        }
    ```
    
    Your boolean works fine too.


> WicketTester.destroy sometimes hangs
> ------------------------------------
>
>                 Key: WICKET-6603
>                 URL: https://issues.apache.org/jira/browse/WICKET-6603
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 8.1.0
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Critical
>             Fix For: 8.2.0, 9.0.0
>
>
> Hi all,
> I'm experiencing some jetty-shutdown problems after upgrading from 7.9 to
>  8.1. See the stacktrace below.
> Is there a simple remedy for this? (or a known cause?) It is annoying
>  because this error prevents Jetty from shutting down, and I use this in my
>  tests, so my tests never end... :(
> Btw. I'm on java 10.0.2 and jetty version 9.2.5.v20141112
> {code:java}
> 2018-10-12 11:24:25,738 ERROR - AsynchronousDataStore      -
> java.lang.InterruptedException
>         at 
> java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1259)
>         at 
> java.base/java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:317)
>         at
> java.base/java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:373)
>         at
> org.apache.wicket.pageStore.AsynchronousDataStore.storeData(AsynchronousDataStore.java:207)
>         at
> org.apache.wicket.pageStore.AbstractPageStore.storePageData(AbstractPageStore.java:119)
>         at
> org.apache.wicket.pageStore.DefaultPageStore.storePage(DefaultPageStore.java:66)
>         at
> org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run(AsynchronousPageStore.java:225)
>         at java.base/java.lang.Thread.run(Thread.java:844)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)