[
https://issues.apache.org/jira/browse/WICKET-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357152#comment-17357152
]
ASF GitHub Bot commented on WICKET-6888:
----------------------------------------
rkurucz9 commented on pull request #471:
URL: https://github.com/apache/wicket/pull/471#issuecomment-854116236
> I've taken a second look and actually your solution is very good. You
clearly have understood how to work with components :).
>
> My major grieve is how the collection of expanded objects is held in the
component tree: this defies the 'holy mantra of detachment', i.e. the selected
entities will get serialized along with the page. You could take a look at
AbstractTree#newModel() for inspiration how this can be avoided.
I hope I could fix it properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ToggleableDataTable
> -------------------
>
> Key: WICKET-6888
> URL: https://issues.apache.org/jira/browse/WICKET-6888
> Project: Wicket
> Issue Type: New Feature
> Components: wicket-examples, wicket-extensions
> Reporter: Roland Kurucz
> Priority: Minor
>
> Dear All,
> I would like to add a toggleable data table to the codebase. Each row of it
> has an expansion content. I developed it and tried to keep it simple as I
> could do.
> If you will approve my feature request, then I will create a pull request for
> it.
> Best Regards,
> Roland
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
