[
https://issues.apache.org/jira/browse/WICKET-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445900#comment-17445900
]
ASF GitHub Bot commented on WICKET-6935:
----------------------------------------
reiern70 commented on a change in pull request #482:
URL: https://github.com/apache/wicket/pull/482#discussion_r752205791
##########
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigationToolbar.java
##########
@@ -73,16 +68,16 @@ protected PagingNavigator newPagingNavigator(final String
navigatorId,
}
/**
- * Factory method used to create the navigator label that will be used
by the datatable
+ * Factory method used to create the navigator label.
*
* @param navigatorId
* component id navigator label should be created with
* @param table
- * dataview used by datatable
+ * DataTable used by datatable
* @return navigator label that will be used to navigate the data table
*
*/
- protected WebComponent newNavigatorLabel(final String navigatorId,
final DataTable<?, ?> table)
+ protected Component newNavigatorLabel(final String navigatorId, final
DataTable<?, ?> table)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make some datatable related components more reusable
> ----------------------------------------------------
>
> Key: WICKET-6935
> URL: https://issues.apache.org/jira/browse/WICKET-6935
> Project: Wicket
> Issue Type: Improvement
> Reporter: Ernesto Reinaldo Barreiro
> Priority: Minor
>
> Some datatable related components are very restrictive in factory methods
> return types as well as some helper classes are private. This makes reusing
> them difficult in some situations. For instance, if in navigation toolbar
> instead a simple label you want to place a more complex component, e.g. the
> same navigation label + a text filter (a Panel and not a Label).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
