[
https://issues.apache.org/jira/browse/WICKET-6944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472691#comment-17472691
]
ASF subversion and git services commented on WICKET-6944:
---------------------------------------------------------
Commit 934e24d46d654cca184aa0a379ab10fc0c5d1086 in wicket's branch
refs/heads/wicket-9.x from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=934e24d ]
WICKET-6944 Memory leak in WicketEndpoint
Register application listener only once per Application
Signed-off-by: Martin Tzvetanov Grigorov <mgrigo...@apache.org>
(cherry picked from commit 9806e8b1b565f0b680c53df0177e8703c05b4b6a)
> Memory leak in WicketEndpoint
> -----------------------------
>
> Key: WICKET-6944
> URL: https://issues.apache.org/jira/browse/WICKET-6944
> Project: Wicket
> Issue Type: Bug
> Components: wicket-native-websocket
> Affects Versions: 9.7.0
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Major
> Attachments: image-2022-01-10-18-52-42-193.png
>
>
> Our application OOMed yesterday after about 2-3 weeks of continuous uptime.
> We normally deploy every other day, so we never noticed this issue before.
> The heap dump identified the possible culprit as
> {{{}WicketEndpoint$ApplicationListener{}}}:
> !image-2022-01-10-18-52-42-193.png!
> Every new websocket connection registers a new instance of this application
> listener and after a while we ended up with millions of these listeners:
> {code:java}
> @Override
> public void onOpen(Session session, EndpointConfig endpointConfig)
> {
> String appName = getApplicationName(session);
> WebApplication app = (WebApplication) WebApplication.get(appName);
> app.getApplicationListeners().add(new
> ApplicationListener(applicationDestroyed));
> try
> {
> ThreadContext.setApplication(app);
> javaxWebSocketProcessor = new JavaxWebSocketProcessor(session, app,
> endpointConfig);
> }
> finally
> {
> ThreadContext.detach();
> }
> }
> {code}
> Instead of creating a new listener for every connection, the listener should
> be a singleton.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
