[
https://issues.apache.org/jira/browse/WICKET-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477736#comment-17477736
]
ASF GitHub Bot commented on WICKET-6945:
----------------------------------------
martin-g commented on pull request #492:
URL: https://github.com/apache/wicket/pull/492#issuecomment-1015264296
Thank you, @mat128 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MultipartFormComponentListener modifies enctype on invisible forms, leading
> to javascript errors
> ------------------------------------------------------------------------------------------------
>
> Key: WICKET-6945
> URL: https://issues.apache.org/jira/browse/WICKET-6945
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Reporter: Mathieu Mitchell
> Priority: Major
>
> MultipartFormComponentListener is tasked with updating the form 'enctype'
> property in the browser when components' visibility change.
> This is required in some cases because a form could become url-encoded or
> multi-part, depending on the fields present.
> The feature was introduced in response to WICKET-6914.
> A subsequent fix was made to the (enabled by default in all Wicket
> applications) listener to support hidden forms.
> Trying to set the enctype property of invisible forms in the browser resulted
> in javascript errors.
> The fix was submitted to fix WICKET-6921.
> The form visibility problem still occurs in a specific scenario. When a form
> visibility is modified during the onConfigure phase,
> the listener emits statements related to forms that have just been made
> invisible.
> This happens because the code in the listener is hooked to the
> onBeforeRespond phase.
> Evaluating the forms visibility in onAfterRespond allows the listener to
> visit all visible children and allows visibility modification during the
> onConfigure phase.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
