[ https://issues.apache.org/jira/browse/WICKET-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484660#comment-17484660 ]
ASF GitHub Bot commented on WICKET-6950: ---------------------------------------- reiern70 commented on a change in pull request #496: URL: https://github.com/apache/wicket/pull/496#discussion_r795653507 ########## File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/IWebSocketProcessor.java ########## @@ -16,13 +16,20 @@ */ package org.apache.wicket.protocol.ws.api; +import org.apache.wicket.protocol.http.WebApplication; +import org.apache.wicket.protocol.ws.WebSocketSettings; + /** * Processes web socket messages. * * @since 6.0 */ public interface IWebSocketProcessor { + default void onOpen(IWebSocketSession webSocketSession, final WebApplication application) { Review comment: @martin-g I will. I just wanted to get your opinion on the whole thing and double check if there was another way to do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > wicket web-sockets implementation does not allow to configure/access web > socket session on onOpen > ------------------------------------------------------------------------------------------------- > > Key: WICKET-6950 > URL: https://issues.apache.org/jira/browse/WICKET-6950 > Project: Wicket > Issue Type: Improvement > Affects Versions: 10.0.0, 9.7.0 > Reporter: Ernesto Reinaldo Barreiro > Assignee: Ernesto Reinaldo Barreiro > Priority: Major > Fix For: 9.8.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)