[
https://issues.apache.org/jira/browse/WICKET-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485488#comment-17485488
]
ASF GitHub Bot commented on WICKET-6952:
----------------------------------------
theigl removed a comment on pull request #497:
URL: https://github.com/apache/wicket/pull/497#issuecomment-1027288730
OK my previous benchmark was flawed because I created a new buffer for every
run. The new `isEmpty` method for `AppendingStringBuffer` is actually 40-50x
faster for medium-sized buffers.
```
Benchmark Mode Cnt Score Error
Units
StringsBenchmark.bufferFastIsEmpty thrpt 15 1918461027.579 ± 4949234.208
ops/s
StringsBenchmark.bufferIsEmpty thrpt 15 42567269.762 ± 40091.373
ops/s
StringsBenchmark.fastIsEmpty thrpt 15 1910306184.208 ± 4067311.978
ops/s
StringsBenchmark.isEmpty thrpt 15 1804225517.032 ± 1951669.787
ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Performance improvements for Strings.isEmpty
> --------------------------------------------
>
> Key: WICKET-6952
> URL: https://issues.apache.org/jira/browse/WICKET-6952
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 9.7.0
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Minor
>
> {{Strings.isEmpty}} is one of the most called methods in our application and
> consistently shows up as hot in our production profiler.
> Two simple performance optimizations can be tried:
> - Overload the method with a {{String}} parameter, to help the JIT compiler
> with it's decision to inline the method
> - Avoid calling {{String.trim}} if the first character isn't whitespace
> See https://github.com/apache/wicket/pull/497.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
