[
https://issues.apache.org/jira/browse/WICKET-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488825#comment-17488825
]
ASF GitHub Bot commented on WICKET-6954:
----------------------------------------
reiern70 commented on a change in pull request #499:
URL: https://github.com/apache/wicket/pull/499#discussion_r801598355
##########
File path:
wicket-native-websocket/wicket-native-websocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/JavaxWebSocketProcessor.java
##########
@@ -17,15 +17,19 @@
package org.apache.wicket.protocol.ws.javax;
import java.nio.ByteBuffer;
+import java.util.List;
import javax.websocket.EndpointConfig;
import javax.websocket.MessageHandler;
+import javax.websocket.PongMessage;
Review comment:
Server pings client --> client implementation answers with a pong -->
specification does not force client to offer a onping, which is BAD, because
we can't use it for reconnect timeout thing :-(. At least this is what I
understood after googling around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> create standard keep-alive/heartbeat like functionality for web-sockets
> -----------------------------------------------------------------------
>
> Key: WICKET-6954
> URL: https://issues.apache.org/jira/browse/WICKET-6954
> Project: Wicket
> Issue Type: Improvement
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Ernesto Reinaldo Barreiro
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
