[ 
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517789#comment-17517789
 ] 

ASF GitHub Bot commented on WICKET-6969:
----------------------------------------

solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843420871


##########
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketPushBroadcaster.java:
##########
@@ -189,7 +189,20 @@ private void process(final Application application, final 
Collection<IWebSocketC
                                @Override
                                public void run()
                                {
-                                       wsConnection.sendMessage(message);
+                                       if 
(webSocketSettings.isAsynchronousPush())
+                                       {
+                                               if 
(webSocketSettings.getAsynchronousPushTimeout() > 0)
+                                               {
+                                                       
wsConnection.sendMessageAsync(message, 
webSocketSettings.getAsynchronousPushTimeout());
+                                               }
+                                               else {

Review Comment:
   `else {` -> 
   ```
   else
   {
   ```





> allow to process web socket push messages in an asynchronous way.
> -----------------------------------------------------------------
>
>                 Key: WICKET-6969
>                 URL: https://issues.apache.org/jira/browse/WICKET-6969
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Ernesto Reinaldo Barreiro
>            Priority: Major
>
> Currently web socket push messages are  always processed in a synchronous 
> way. Allow to configure applications to use by default asynchronous messages.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to