reiern70 commented on PR #569: URL: https://github.com/apache/wicket/pull/569#issuecomment-1498557849
> Not beautiful, but it seems to work. > > Maybe let #onRequestHandlerResolved() and #onRequestHandlerExecuted() both delegate to a private method #protect() ... the way the one calls the other now I find confusing. This sounds like a goog idea. I will do and push those changes and merge. After that I can try to explore the other idea you proposed (that seems less fragile that doing it this way). Wondering if we should also add some tests covering actual generation of headers for these corrner cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
