[
https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712919#comment-17712919
]
ASF GitHub Bot commented on WICKET-7047:
----------------------------------------
theigl commented on code in PR #579:
URL: https://github.com/apache/wicket/pull/579#discussion_r1168248756
##########
wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java:
##########
@@ -1089,7 +1089,7 @@ public static CharSequence toMultilineMarkup(final
CharSequence s)
return null;
}
- final AppendingStringBuffer buffer = new
AppendingStringBuffer();
+ final AppendingStringBuffer buffer = new
AppendingStringBuffer((int) (s.length() * 1.1));
Review Comment:
I just realized that this has an adverse effect on short strings where the
overhead of `<p></p>` is significantly more than 10%. It makes sense to set a
minimum capacity for the buffer. Either via `Math.max((int)(len * 1.1), 16)` or
by always adding the default capacity of 16 to the length.
> Improve initial buffer capacity for Strings.toMultilineMarkup
> -------------------------------------------------------------
>
> Key: WICKET-7047
> URL: https://issues.apache.org/jira/browse/WICKET-7047
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 9.12.0
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Minor
>
> We currently create an AppendingStringBuffer with default capacity of 16 in
> Strings#toMultilineMarkup. Since we know the size of the original string and
> can take a guess at the additional length required for markup, it makes sense
> to size this buffer appropriately.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
