[ 
https://issues.apache.org/jira/browse/WICKET-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755636#comment-17755636
 ] 

Sven Meier commented on WICKET-7067:
------------------------------------

I wonder whether this is the right place to disable caching in general (not 
only for WebSocketResponse) - what if an exception mapper maps to a static 
resource which should indeed be cached?

> DefaultExceptionMapper should not set disableCaching for  WebSocketResponse
> ---------------------------------------------------------------------------
>
>                 Key: WICKET-7067
>                 URL: https://issues.apache.org/jira/browse/WICKET-7067
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 10.0.0-M1, 9.14.0
>            Reporter: Ernesto Reinaldo Barreiro
>            Assignee: Ernesto Reinaldo Barreiro
>            Priority: Major
>             Fix For: 9.15.0, 10.0.0-M2
>
>
> @Override
> public IRequestHandler map(Exception e)
> {
> try
> {
> Response response = RequestCycle.get().getResponse();
> if (response instanceof WebResponse)
> {
> // we don't want to cache an exceptional reply in the browser
> ((WebResponse)response).disableCaching();
> }
> return internalMap(e);
> }
> catch (RuntimeException e2)
> {
> return handleNestedException(e, e2);
> }
> }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to