solomax commented on code in PR #601:
URL: https://github.com/apache/wicket/pull/601#discussion_r1303788210
##########
wicket-core/src/test/java/org/apache/wicket/markup/MarkupParserTest.java:
##########
@@ -133,12 +133,12 @@ final void test1() throws Exception
log.info("tok(4)=" + tokens.get(4));
log.info("tok(5)=" + tokens.get(5));
- assertTrue(tokens.get(0).equals("This is a test "));
+ assertEquals("This is a test ", tokens.get(0));
Review Comment:
`tokens.get(0)` is of type `RawMarkup`
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/RawMarkup.java
so `tokens.get(0).equals(_some_string_)` works due to `equals` implementation
this assert need to be rewritten as
`assertEquals("This is a test ", tokens.get(0).toCharSequence());`
OR
`assertEquals("This is a test ", tokens.get(0).toString());`
also other 2 asserts with `tokens.get()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
