[ https://issues.apache.org/jira/browse/WICKET-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803067#comment-17803067 ]
ASF GitHub Bot commented on WICKET-7090: ---------------------------------------- papegaaij commented on code in PR #758: URL: https://github.com/apache/wicket/pull/758#discussion_r1441675290 ########## wicket-auth-roles/pom.xml: ########## @@ -24,7 +24,7 @@ <relativePath>../pom.xml</relativePath> </parent> <artifactId>wicket-auth-roles</artifactId> - <packaging>bundle</packaging> + <packaging>jar</packaging> Review Comment: As far as I know, it shouldn't. A jar is an OSGi bundle, when it's manifest contains OSGi related information, but it's still a jar. The documentation for the maven-bundle-plugin even describes this setup as a valid solution: https://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#_adding_osgi_metadata_to_existing_projects_without_changing_the_packaging_type > Files in release jars do not have a modification timestamp set > -------------------------------------------------------------- > > Key: WICKET-7090 > URL: https://issues.apache.org/jira/browse/WICKET-7090 > Project: Wicket > Issue Type: Bug > Components: release > Affects Versions: 9.8.0, 9.9.0, 9.10.0, 9.11.0, 9.12.0, 9.13.0, 9.14.0, > 9.15.0, 9.16.0 > Reporter: Emond Papegaaij > Assignee: Emond Papegaaij > Priority: Minor > > Starting with 9.8.0, the release jars are built with file entries without a > last modification timestamp. This can cause issues if > {{LastModifiedResourceVersion}} used for the {{{}resourceCachingStrategy{}}}. > The browser may be using an older version of the resource, even if a newer > version is available. This strategy is normally only used in development > mode, but even then this can cause unexpected behavior. > As discussed on the dev list, the best we can do is to set the last > modification timestamp to fixed time during the release, as git doesn't track > this. A suggestion is to useĀ the project.build.outputTimestamp property: > https://maven.apache.org/guides/mini/guide-reproducible-builds.html -- This message was sent by Atlassian Jira (v8.20.10#820010)