papegaaij commented on code in PR #758:
URL: https://github.com/apache/wicket/pull/758#discussion_r1442721690
##########
wicket-auth-roles/pom.xml:
##########
@@ -24,7 +24,7 @@
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-auth-roles</artifactId>
- <packaging>bundle</packaging>
+ <packaging>jar</packaging>
Review Comment:
@mattrpav This change is to get correct timestamps on files (also called
entries) in the jar files. The maven-bundle-plugin does not set these
timestamps at all, causing them to revert to the jar-epoch (02-01-1980). The
maven-jar-plugin honors `project.build.outputTimestamp`. If it also gives us
reproducible builds, that's a bonus but not the reason for this change.
We do however not want to break OSGi support. However, none of the Wicket
core developers uses OSGi, so this is very hard for us to test. With this
change, the produced jars *should* still be valid OSGi bundles, but we have no
good way to verify this. It be really great of you could check this.
As far as I know OSGi, the only thing that makes a normal jar an OSGi bundle
is a set of entries in the MANIFEST.MF. These all seem unaffected by this
change (I compared before and after), so I think the change is correct. But
maybe you can point to something else that must be in place for an OSGi bundle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
