svenmeier commented on code in PR #762:
URL: https://github.com/apache/wicket/pull/762#discussion_r1447218599
##########
wicket-core/src/main/java/org/apache/wicket/page/PartialPageUpdate.java:
##########
@@ -567,7 +567,7 @@ public final void add(final Component component, final
String markupId)
LOG.warn("Component '{}' not cannot be updated
because it was already removed from page", component);
return;
}
- else if (pageOfComponent != page)
+ else if (!pageOfComponent.equals(page))
Review Comment:
Changing #equals and #hashCode in such a central class can have severe
negative consequence, that I would not like to risk.
Your idea with updating via component path sounds good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
