[ https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815720#comment-17815720 ]
Thomas Heigl commented on WICKET-6890: -------------------------------------- OK I'm not a big fan of this change. Disabling tag stripping breaks our layout in a lot of places. [~mgrigorov]: I think we need an enum for this after all. > Render debug setting 'outputMarkupContainerClassName` as an attribute > --------------------------------------------------------------------- > > Key: WICKET-6890 > URL: https://issues.apache.org/jira/browse/WICKET-6890 > Project: Wicket > Issue Type: Improvement > Components: wicket-core > Reporter: Martin Tzvetanov Grigorov > Assignee: Martin Tzvetanov Grigorov > Priority: Major > Fix For: 10.0.0-M1 > > > As discussed at [https://markmail.org/message/uoxxlnbz56ex7vuk] when > org.apache.wicket.settings.DebugSettings#isOutputMarkupContainerClassName() > returns true then the MarkupContainer class name should be rendered as an > attribute of the component tag instead of as an HTML comment because an HTML > comment may break a CSS rule, e.g. by appearing between two sibling HTML > elements > {code:java} > p + p {color: red;} {code} > > The CSS rule above will change the text color of any paragraph that follows > another paragraph. But if an HTML comment appears between them then the rule > won't apply. -- This message was sent by Atlassian Jira (v8.20.10#820010)