[
https://issues.apache.org/jira/browse/WICKET-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815936#comment-17815936
]
Martin Tzvetanov Grigorov edited comment on WICKET-6890 at 2/9/24 7:33 AM:
---------------------------------------------------------------------------
I believe the change is worth it!
I didn't keep a track of the reports that the debug HTML elements break the UI
but there were several of them during the years!
Feel free to provide a PR with improvements (e.g. the enum based approach)!
I'll be OK the old way to be the default!
was (Author: mgrigorov):
I believe the change is worth it!
I didn't keep a track of the reports that the debug HTML elements break the UI
but there were several of them during the years!
Feel free to provide a PR with improvements (e.g. the enum based approach)!
> Render debug setting 'outputMarkupContainerClassName` as an attribute
> ---------------------------------------------------------------------
>
> Key: WICKET-6890
> URL: https://issues.apache.org/jira/browse/WICKET-6890
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Fix For: 10.0.0-M1
>
>
> As discussed at [https://markmail.org/message/uoxxlnbz56ex7vuk] when
> org.apache.wicket.settings.DebugSettings#isOutputMarkupContainerClassName()
> returns true then the MarkupContainer class name should be rendered as an
> attribute of the component tag instead of as an HTML comment because an HTML
> comment may break a CSS rule, e.g. by appearing between two sibling HTML
> elements
> {code:java}
> p + p {color: red;} {code}
>
> The CSS rule above will change the text color of any paragraph that follows
> another paragraph. But if an HTML comment appears between them then the rule
> won't apply.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
