[ https://issues.apache.org/jira/browse/WICKET-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831916#comment-17831916 ]
ASF GitHub Bot commented on WICKET-7101: ---------------------------------------- reiern70 commented on code in PR #812: URL: https://github.com/apache/wicket/pull/812#discussion_r1543387516 ########## wicket-core/src/main/java/org/apache/wicket/ajax/form/AjaxFormComponentUpdatingBehavior.java: ########## @@ -157,7 +158,7 @@ protected final void onEvent(final AjaxRequestTarget target) { onError(target, e); } - formComponent.updateAutoLabels(target); + formComponent.updateAutoLabels((IPartialPageRequestHandler)target, false); Review Comment: Not really. > auto-label is not automatically updated when related form component is > updated. > ------------------------------------------------------------------------------- > > Key: WICKET-7101 > URL: https://issues.apache.org/jira/browse/WICKET-7101 > Project: Wicket > Issue Type: Improvement > Reporter: Ernesto Reinaldo Barreiro > Assignee: Ernesto Reinaldo Barreiro > Priority: Major > Fix For: 10.1.0, 9.18.0 > > > Auto-labels are somewhat disconnected from FormComponent they are bound to in > the sense that: > > * You can modify the form component (e.g. if it is required) and update that > component via AJAX and > * Autolabel will stay with a stale state: i.e. still with the required CSS > class > This should be fixed with > > [https://github.com/apache/wicket/pull/812] > > This PR introduces: > * a new tag *wicket:auto='true|false'* that allows to set some auto label as > updatable always that form component is updated (via AJAX or web socket > request). > * a new boolean flag on markup-settings that allows to set this new behavior > as application default. By default, the flag is set to false thus that > applications keep existing behavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)