martin-g commented on code in PR #928: URL: https://github.com/apache/wicket/pull/928#discussion_r1701515764
########## wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java: ########## @@ -46,13 +46,14 @@ public ListenerInvocationNotAllowedException(Component component, Behavior behav this.behavior = behavior; } - private static String detail(Component component, - Behavior behavior) + private static String detail(Component component, Behavior behavior) { StringBuilder detail = new StringBuilder("Component: ").append(component.toString(false)); + detail.append(" Path: ").append(component.getPath()); Review Comment: ```suggestion detail.append(", path: ").append(component.getPath()); ``` ########## wicket-core/src/main/java/org/apache/wicket/settings/DebugSettings.java: ########## @@ -62,6 +62,11 @@ public class DebugSettings private boolean developmentUtilitiesEnabled = false; + /** + * Configure noisy Logging in Exceptions + */ + private boolean loudExceptionLogging = true; Review Comment: We have https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/settings/ExceptionSettings.java Maybe it is a better place for this new setting ?! ########## wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java: ########## @@ -46,13 +46,14 @@ public ListenerInvocationNotAllowedException(Component component, Behavior behav this.behavior = behavior; } - private static String detail(Component component, - Behavior behavior) + private static String detail(Component component, Behavior behavior) { StringBuilder detail = new StringBuilder("Component: ").append(component.toString(false)); + detail.append(" Path: ").append(component.getPath()); + if (behavior != null) { - detail.append(" Behavior: ").append(behavior.toString()); + detail.append(" Behavior: ").append(behavior); Review Comment: ```suggestion detail.append(", behavior: ").append(behavior); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@wicket.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org