[ 
https://issues.apache.org/jira/browse/WICKET-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viliam Repan updated WICKET-7123:
---------------------------------
    Description: 
Currently Form.setDefaultButton() support only one button per whole form 
hierarchy, which is a problem when there are multiple forms on page of for 
example popup. It complicates even further when those default submit buttons 
have custom visibility/enabled state.

Current implementation puts hidden field in root form which stores name of 
submit button and then creates client JS click() via jquery.

This should be easy doable directly on form where the default button is located 
without the need to pass it to root form.

What do you think about this?

PR available here https://github.com/apache/wicket/pull/968

  was:
Currently Form.setDefaultButton() support only one button per whole form 
hierarchy, which is a problem when there are multiple forms on page of for 
example popup. It complicates even further when those default submit buttons 
have custom visibility/enabled state.

Current implementation puts hidden field in root form which stores name of 
submit button and then creates client JS click() via jquery.

This should be easy doable directly on form where the default button is located 
without the need to pass it to root form.

What do you think about this?

I'll provide PR for this.


> Form.setDefaultButton() supports only one button per form hierarchy
> -------------------------------------------------------------------
>
>                 Key: WICKET-7123
>                 URL: https://issues.apache.org/jira/browse/WICKET-7123
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 10.1.0
>            Reporter: Viliam Repan
>            Priority: Major
>
> Currently Form.setDefaultButton() support only one button per whole form 
> hierarchy, which is a problem when there are multiple forms on page of for 
> example popup. It complicates even further when those default submit buttons 
> have custom visibility/enabled state.
> Current implementation puts hidden field in root form which stores name of 
> submit button and then creates client JS click() via jquery.
> This should be easy doable directly on form where the default button is 
> located without the need to pass it to root form.
> What do you think about this?
> PR available here https://github.com/apache/wicket/pull/968



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to