This is an automated email from the ASF dual-hosted git repository.

mgrigorov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/master by this push:
     new bb5a7b34b0 Try to fix the build at Github Actions CI (#1004)
bb5a7b34b0 is described below

commit bb5a7b34b0ab31e5cb73f24e9c86b1789c9b91a7
Author: Martin Grigorov <[email protected]>
AuthorDate: Tue Oct 15 09:35:24 2024 +0300

    Try to fix the build at Github Actions CI (#1004)
    
    * Try to fix the build at Github Actions CI
    
    * Update some Ubuntu packages for 24.04
    * Update Maven to 3.9.9
    * Build with JDK 23 instead of 22
    
    Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    
    * Do not try to build with JDK 23 for now
    
    It seems we need a newer version of OpenRewrite:
    
    ```
            at java.base/java.util.ArrayList.forEach(ArrayList.java:1597)
    Caused by: java.lang.AssertionError: Failed to parse sources or run recipe
            at 
org.openrewrite.test.RewriteTest.lambda$defaultExecutionContext$15(RewriteTest.java:633)
            at 
org.openrewrite.java.isolated.ReloadableJava21ParserVisitor.convert(ReloadableJava21ParserVisitor.java:1688)
            at 
org.openrewrite.java.isolated.ReloadableJava21ParserVisitor.visitCompilationUnit(ReloadableJava21ParserVisitor.java:536)
            at 
org.openrewrite.java.isolated.ReloadableJava21ParserVisitor.visitCompilationUnit(ReloadableJava21ParserVisitor.java:73)
            at 
com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:625)
            at com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:92)
            at 
org.openrewrite.java.isolated.ReloadableJava21Parser.lambda$parseInputs$0(ReloadableJava21Parser.java:166)
            ... 15 more
    Caused by: org.openrewrite.java.JavaParsingException: Failed to convert for 
the following cursor stack:--- BEGIN PATH ---
    JCCompilationUnit(sourceFile = 
org/apache/wicket/http2/markup/head/PushHeaderItem.java)
    --- END PATH ---
    
            ... 21 more
    Caused by: java.lang.NoSuchMethodError: 
'com.sun.tools.javac.tree.DCTree$DCDocComment 
com.sun.tools.javac.tree.DocCommentTable.getCommentTree(com.sun.tools.javac.tree.JCTree)'
            at 
org.openrewrite.java.isolated.ReloadableJava21ParserVisitor.convert(ReloadableJava21ParserVisitor.java:1665)
            ... 20 more
    ```
    
    Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
    
    ---------
    
    Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
---
 .github/workflows/maven.yml | 5 ++---
 pom.xml                     | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 82b1e2216d..a59622b26f 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -7,7 +7,7 @@ on:
     branches: [ master ]
 
 env:
-  MAVEN_VERSION: 3.9.6
+  MAVEN_VERSION: 3.9.9
 
 jobs:
   build:
@@ -19,7 +19,6 @@ jobs:
         - '17'
         - '21'
         - '22'
-#        - '23-ea'
 
     steps:
     - uses: actions/checkout@v4
@@ -34,7 +33,7 @@ jobs:
       run: sudo apt update
 
     - name: Install Puppeteer's dependencies
-      run: sudo apt-get install -y chromium-browser fonts-ipafont-gothic 
fonts-wqy-zenhei fonts-thai-tlwg fonts-kacst fonts-freefont-ttf gconf-service 
libasound2 libatk1.0-0 libatk-bridge2.0-0 libc6 libcairo2 libcups2 libdbus-1-3 
libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 
libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 
libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 
libxi6 libxrandr2 libxrender1  [...]
+      run: sudo apt-get install -y chromium-browser fonts-ipafont-gothic 
fonts-wqy-zenhei fonts-thai-tlwg fonts-kacst fonts-freefont-ttf libasound2t64 
libatk1.0-0 libatk-bridge2.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 
libfontconfig1 libgcc1 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 
libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 
libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 
libxrender1 libxss1 libxtst6 ca-cert [...]
 
     - name: Install Maven
       run: |
diff --git a/pom.xml b/pom.xml
index f456a1f131..4d03fd77eb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1472,7 +1472,7 @@
                <profile>
                        <id>on-jdk-early-access</id>
                        <activation>
-                               <jdk>[23,)</jdk>
+                               <jdk>[24,)</jdk>
                        </activation>
                        <properties>
                                
<javadoc.jdk.apidocs.link>https://download.java.net/java/early_access/jdk${java.specification.version}/docs/api/</javadoc.jdk.apidocs.link>

Reply via email to