dougdonohoe commented on code in PR #436: URL: https://github.com/apache/wicket/pull/436#discussion_r1832612700
########## wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlEncoder.java: ########## @@ -16,58 +16,139 @@ */ package org.apache.wicket.util.encoding; -import java.io.CharArrayWriter; +import java.io.ByteArrayOutputStream; import java.io.UnsupportedEncodingException; import java.nio.charset.Charset; import java.nio.charset.IllegalCharsetNameException; import java.nio.charset.UnsupportedCharsetException; -import java.util.BitSet; import org.apache.wicket.util.lang.Args; /** - * Adapted from java.net.URLEncoder, but defines instances for query string encoding versus URL path + * Adapted from Spring Framework's UriUtils class, but defines instances for query string encoding versus URL path * component encoding. * <p/> * The difference is important because a space is encoded as a + in a query string, but this is a * valid value in a path component (and is therefore not decode back to a space). - * - * @author Doug Donohoe - * @see java.net.URLEncoder + * + * @author Thomas Heigl Review Comment: I happened to be looking at Wicket source code again and noticed this change. I'm the original author of the UrlDecode, originating back in 2008 in https://issues.apache.org/jira/browse/WICKET-1627. This @author change is not cool. It should at least be: ``` @author Doug Donohoe @author Thomas Heigl ``` CC: @theigl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
