[ 
https://issues.apache.org/jira/browse/WICKET-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897071#comment-17897071
 ] 

ASF GitHub Bot commented on WICKET-7024:
----------------------------------------

pedrosans commented on PR #1030:
URL: https://github.com/apache/wicket/pull/1030#issuecomment-2467177691

   The PackageResource handling in Wicket 9 and forward have diverged enough 
that the tests in this pull request won't work, even after reverting the 
changes in the core classes. 




> Wrong static resource urls when their generation is triggered by <wicket:link>
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-7024
>                 URL: https://issues.apache.org/jira/browse/WICKET-7024
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 9.12.0
>            Reporter: Martin Tzvetanov Grigorov
>            Priority: Major
>         Attachments: wicket-link-leak.tgz
>
>
> If an application uses <wicket:link> to generate a url for a static resource, 
> e.g.
> {code:java}
> <html xmlns="http://www.w3.org/1999/xhtml"; 
> xmlns:wicket="http://wicket.apache.org/";>
> <head>
> <wicket:head>
>   <wicket:link>
>     <link rel="stylesheet" type="text/css" href="css/test2.css"  />
>   </wicket:link>
> </wicket:head>
> </head>
> ...  {code}
> then during the page render time it will use
> {code:java}
> CharSequence url = getRequestCycle().urlFor(handler); {code}
> and 
> [https://github.com/apache/wicket/blob/bc70f127ff74f154890a35be906b55db5bdc8683/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java#L117-L128]
>  will use the current page's url and try to parse locale/style/variation from 
> it and embed it in the static resource url.
> The problem is that it uses the pageId/renderCount/behaviorId and component 
> path instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to