[ 
https://issues.apache.org/jira/browse/WICKET-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898442#comment-17898442
 ] 

ASF GitHub Bot commented on WICKET-3899:
----------------------------------------

pedrosans opened a new pull request, #1033:
URL: https://github.com/apache/wicket/pull/1033

   visiting
   
    - removing traversal signaling dead code
    - test if form validator dependent components are enabled and form 
participants
    - internalMarkFormComponentsValid in postorder
    - updateNestedFormComponentModels in postorder
    - internalOnValidateModelObjects in porstorder




> IFormVisitorParticipant don't get tested when validation method is visiting 
> inner forms
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-3899
>                 URL: https://issues.apache.org/jira/browse/WICKET-3899
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.17, 1.5-RC5.1
>            Reporter: Pedro Santos
>            Assignee: Pedro Santos
>            Priority: Major
>         Attachments: WICKET-3899-fix-test.patch, WICKET-3899.patch
>
>
> The inconsistencies is at Form#validate method. It invokes 
> validateNestedForms and validateComponents, but only the second one uses a 
> visitor filter testing for IFormVisitorParticipant#processChildren value.
> More about: http://markmail.org/message/q2qfuyg3gcrurxxp



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to