This is an automated email from the ASF dual-hosted git repository. adelbene pushed a commit to branch wicket-9.x in repository https://gitbox.apache.org/repos/asf/wicket.git
commit d0c8035fd2b4b49d6f8110d563c3b940960c09d4 Author: Erik Strid <[email protected]> AuthorDate: Sun Nov 24 10:39:23 2024 +0100 Renamed the TabBehavior to KeyTabBehavior --- .../autocomplete/AbstractAutoCompleteBehavior.java | 4 ++-- .../html/autocomplete/AutoCompleteSettings.java | 21 +++++++++++---------- .../markup/html/autocomplete/wicket-autocomplete.js | 2 +- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java index 7b766b7a89..166b9fea1e 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AbstractAutoCompleteBehavior.java @@ -187,8 +187,8 @@ public abstract class AbstractAutoCompleteBehavior extends AbstractDefaultAjaxBe { sb.append(",className: '").append(settings.getCssClassName()).append('\''); } - sb.append(",tabBehavior: '").append( - settings.getTabBehavior().getValue()).append('\''); + sb.append(",keyTabBehavior: '").append( + settings.getKeyTabBehavior().getValue()).append('\''); sb.append('}'); return sb.toString(); } diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java index d243350f76..010846686a 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java @@ -74,7 +74,7 @@ public final class AutoCompleteSettings implements IClusterable private int minInputLength = 1; - private TabBehavior tabBehavior = TabBehavior.SELECT_FOCUS_NEXT_ELEMENT; + private KeyTabBehavior keyTabBehavior = KeyTabBehavior.SELECT_FOCUS_NEXT_ELEMENT; /** * Indicates whether the first item in the list is automatically selected when the autocomplete @@ -384,25 +384,25 @@ public final class AutoCompleteSettings implements IClusterable /** * Indicates how the Tab key should be handled when having an item in the autocomplete list - * selected, {@link TabBehavior#SELECT_FOCUS_NEXT_ELEMENT} is the default behavior. + * selected, {@link KeyTabBehavior#SELECT_FOCUS_NEXT_ELEMENT} is the default behavior. * * @return the behavior that should be used when the Tab key is pressed */ - public TabBehavior getTabBehavior() + public KeyTabBehavior getKeyTabBehavior() { - return tabBehavior; + return keyTabBehavior; } /** * Set how the Tab key should be handled when having an item in the autocomplete list selected. * - * @param tabSelectBehavior the behavior that should be used when the Tab key is pressed, - * {@link TabBehavior#SELECT_FOCUS_NEXT_ELEMENT} is the default behavior + * @param keyTabBehavior the behavior that should be used when the Tab key is pressed, + * {@link KeyTabBehavior#SELECT_FOCUS_NEXT_ELEMENT} is the default behavior * @return this {@link AutoCompleteSettings} */ - public AutoCompleteSettings setTabBehavior(TabBehavior tabSelectBehavior) + public AutoCompleteSettings setKeyTabBehavior(KeyTabBehavior keyTabBehavior) { - this.tabBehavior = tabSelectBehavior; + this.keyTabBehavior = keyTabBehavior; return this; } @@ -410,7 +410,8 @@ public final class AutoCompleteSettings implements IClusterable * A behavior that can be used to control how the Tab key should be handled when having an item * in the autocomplete list is marked. */ - public enum TabBehavior { + public enum KeyTabBehavior + { /** * Select the currently marked item and move the focus to the next focusable element. */ @@ -422,7 +423,7 @@ public final class AutoCompleteSettings implements IClusterable private final String value; - TabBehavior(String value) + KeyTabBehavior(String value) { this.value = value; } diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js index 7f338fb7cd..fb91147f45 100644 --- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js +++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js @@ -184,7 +184,7 @@ hideAutoComplete(); - if (cfg.tabBehavior === 'selectFocusAutocompleteInput' && keyCode === KEY_TAB) { + if (cfg.keyTabBehavior === 'selectFocusAutocompleteInput' && keyCode === KEY_TAB) { // prevent moving focus to the next component if an item in the dropdown is selected // using the Tab key jqEvent.preventDefault();
